Fix microphone desynchronization issues #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the excellent PR. I am currently updating another feature and will merge this PR as soon as that is finished. |
|
Almost a year later but thank you for this PR! Noticed the exact issue and I'm grateful someone worked on it. 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Sometimes when using
uLipSyncMicrophonetheMicrophoneandAudioSourcebecome out of sync.One way to reproduce this problem is to pause the editor while the scene is running.
This results in a delay between spoken words and detection.
Similar problems can occur when the microphone is momentarily disconnected due to a bad cable or buggy drivers.
Changes
AudioSourceplayback position toMicrophoneplayback position when they become out of syncMicrophoneif it stops recording whileisRecordingis trueThank you hecomi for this amazing library!
I like it very much.