Skip to content

Conversation

liudger
Copy link
Contributor

@liudger liudger commented Aug 25, 2022

initial support for Unity Animator #8

initial support for Unity Animator
@liudger liudger changed the title Add support for Animator #8 Add support for Animator Aug 25, 2022
@hecomi
Copy link
Owner

hecomi commented Aug 29, 2022

Thank you for the pull request. I am currently working on organizing the animation baking mechanism and texture support, and will try to integrate the animator support code you provided after these codes are sorted out. Please give me some time.

@liudger liudger marked this pull request as draft October 5, 2022 10:06
@hecomi hecomi merged commit 3b7f36e into hecomi:main Dec 27, 2022
@hecomi
Copy link
Owner

hecomi commented Dec 27, 2022

Sorry for the very late response. I have made some modifications to the code you provided and merged it. Thanks for the great PR!

@liudger
Copy link
Contributor Author

liudger commented Dec 27, 2022

Sorry for the very late response. I have made some modifications to the code you provided and merged it. Thanks for the great PR!

Thanks, it needed indeed some fixes that was why I converted it too draft. I'll have a look. The code that I locally tested was working well. If needed I could make another pull request with the tweaks to reduce warnings.

@hecomi
Copy link
Owner

hecomi commented Dec 28, 2022

I have modified the code to fit the style of this project and tried to get rid of all warnings/errors I noticed.

If you notice the other bugs, I would be very happy to receive a new PR or an issue report 🙇‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants