[HxGrid] removal of CTS disposal + tests #1075
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes the disposal of the cancellation token source (CTS) in HxGrid to mitigate potential ObjectDisposedException issues when tasks are still running, while adding tests to verify the cancellation behavior remains correct.
- Removed CTS disposal in HxGrid.razor.cs and set it to null instead
- Added tests in HxGrid_Cancellation_Tests.cs to validate cancellation behavior after component disposal
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| HxGrid.razor.cs | Removed disposal of the CTS with an explanatory comment to prevent ObjectDisposedException issues that can occur when tasks still reference the CTS |
| HxGrid_Cancellation_Tests.cs | Introduced tests to ensure cancellation is requested properly and that no ObjectDisposedException is thrown after component disposal |
|
I guess NOT OK, see line 730 in HxGrid.razor.cs |
There was a problem hiding this comment.
Pull Request Overview
This PR removes the disposal of the CancellationTokenSource in the HxGrid component to avoid potential ObjectDisposedExceptions and adds tests to verify proper cancellation behavior when the component is disposed.
- Removed CTS disposal in RefreshPaginationOrLoadMoreDataCoreAsync and Dispose method
- Added tests to ensure cancellation behavior works as intended
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| HxGrid.razor.cs | Removed CTS disposal to prevent ObjectDisposedExceptions and reinitialized it on refresh/dispose |
| HxGrid_Cancellation_Tests.cs | Added tests to validate cancellation behavior when the grid is disposed |
@jirikanda Please review. If you're good with the change, I'll go ahead and update a few other components that currently dispose the CTS (
HxAutosuggest,HxSearchBox,HxInputTags, etc.).Also, we could try setting
_paginationRefreshDataCancellationTokenSourcetonullonce the data load operation finishes (both QuickGrid and FluentUI-DataGrid do this so the GC can collect the CTS ASAP), though it probably won't make much of a difference.Reference implementations: