Update deps #731
Merged
Update deps #731
+329
−337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates dependency versions and adapts the code to work with the new API of hickory_resolver.
- Revised resolver instantiation in src/lib.rs and src/client.rs using the new builder pattern.
- Updated dependency versions in Cargo.toml (e.g., average, rand, hickory-resolver, rusqlite, jsonschema).
- Adjusted error conversion in the ClientError enum to align with the change in hickory_resolver error types.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/lib.rs | Modified resolver initialization to use the new builder API. |
| src/client.rs | Updated resolver type and error conversion; changed default setup. |
| Cargo.toml | Upgraded dependency versions to support new API features. |
Comments suppressed due to low confidence (1)
src/client.rs:134
- The error conversion now uses hickory_resolver::ResolveError (instead of hickory_resolver::error::ResolveError); please confirm that this change is intentional and that consumers of this API are updated accordingly.
ResolveError(#[from] Box<hickory_resolver::ResolveError>),
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.