Implement experimental HTTP3 support #746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hatoo
requested changes
Jun 3, 2025
Cargo.toml
Outdated
| @@ -60,6 +67,13 @@ rustls-native-certs = { version = "0.8.0", optional = true } | |||
| tokio-rustls = { version = "0.26.0", optional = true } | |||
| rustls-pki-types = { version = "1.7.0", optional = true } | |||
|
|
|||
| h3 = { version = "0.0.7", optional = true } | |||
| h3-quinn = { version = "0.0.9", optional = true } | |||
| quinn-proto = { version = "*", optional = true, features = ["aws-lc-rs"]} | |||
There was a problem hiding this comment.
Why can't we specify version?
Please add some comment if there are some reason.
| @@ -21,12 +21,15 @@ This program is built on stable Rust, with both `make` and `cmake` prerequisites | |||
|
|
|||
| You can optionally build oha against [native-tls](https://github.com/sfackler/rust-native-tls) instead of [rustls](https://github.com/rustls/rustls). | |||
|
|
|||
| cargo install --no-default-features --features rustls oha | |||
| cargo install --no-default-features --features native-tls oha | |||
hatoo
approved these changes
Jun 4, 2025
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the h3 library to implement HTTP3 support. Added to all paths - debug, 'standard' and 'fast'. Initial integration test support, however needs more tests to be fully fleshed out.
While H1 and H2 are supported by higher-level abstractions in Hyper, Hyper doesn't have those equivalents for H3 yet. So we must write them ourselves. We have implemented only as much as is necessary for load testing.
This is titled 'experimental' because the H3 crate is still marked as 'experimental'. In practice, it seems to work very well.
Much of the functionality is copied exactly from HTTP2, including the naming of all the functions in client_h3.rs. This should make it easier to review and understand - simply compare to the HTTP2 equivalent.
The main difference is that H3 returns a driver which must be continuously polled to drive the connection until we are finished with it.
HTTP3 also doesn't support unencrypted connections or HTTP1 proxies, so there's a good amount of functionality in Oha we don't have to extend for this H3 implementation.
To test it, you can use the examples in h3 as a server. For example,