Skip to content

Add -u/--time-unit option #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025
Merged

Add -u/--time-unit option #741

merged 2 commits into from
May 30, 2025

Conversation

kntng
Copy link
Contributor

@kntng kntng commented May 30, 2025

Adds support for the time unit option mentioned in #597.

Some decisions made:

  • Uses max latency (slowest request) instead of mean (as in the example in the issue) to automatically determine unit if not provided. The main reason being that mean latency may be an order of magnitude smaller than slowest and therefore you will often get microseconds instead of milliseconds by default.
  • Limits TUI view to milliseconds. This is because in microseconds and nanoseconds, the numbers appear as -inf or NaN, and its not really practical anyways to view the last n microseconds or nanoseconds.
  • This option is only supported in text summary (similar to the example mentioned in the issue).

I will post some example outputs in the issue thread.

Copy link
Owner

@hatoo hatoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No probrem.

@hatoo hatoo merged commit 48887fa into hatoo:master May 30, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants