Skip to content

Package files #2813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 21, 2017
Merged

Package files #2813

merged 3 commits into from
Jun 21, 2017

Conversation

koenpunt
Copy link
Contributor

@koenpunt koenpunt commented Apr 22, 2017 •
edited
Loading

Summary

As a (late) follow up on my comment here, this change makes it so that all compiled source files are now included in the package for bower and npm.

fixes both #2804 and #2635

NB. Not sure if this counts as a bug fix or a feature, because if it's the latter, this is not to be merged according to our so-called feature-stop.

tjschuck
tjschuck approved these changes Apr 26, 2017
View reviewed changes
Copy link
Member

@tjschuck tjschuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📦

@koenpunt koenpunt merged commit 0d739b8 into master Jun 21, 2017
@koenpunt koenpunt deleted the package-files branch June 21, 2017 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjschuck tjschuck tjschuck approved these changes

+1 more reviewer

@stof stof stof approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koenpunt @tjschuck @stof