Skip to content

Conversation

hanoii
Copy link

@hanoii hanoii commented Aug 10, 2016

Summary

An alternative to #2618 that simply allows for a custom process results callback to be set.

If something like this is really going to be considered, I'll improve/work on the documentation.

Please double-check that:

  • All changes were made in CoffeeScript files, not JavaScript files.
  • You used Grunt to build the JavaScript files and tested them locally.
  • You've updated both the jQuery and Prototype versions.
  • You haven't manually updated the version number in package.json.
  • If necessary, you've updated the documentation.

References

@koenpunt
Copy link
Contributor

koenpunt commented Aug 10, 2016

I appreciate the eagerness of making Chosen better, but I think this is not very useful –except for you– because this requires a full reimplementation of the function, with option and option-group handling etc..
If only we make the Chosen object available (something like I started here: #1647), you can monkey-patch any of the methods,

@hanoii
Copy link
Author

hanoii commented Aug 10, 2016

Well, for me and quite a few that commented on the parent issue, as well as other references to that issue as well. Although yes, I know, a handful. It was nice to see @davereid, a fellow Drupaler, commenting on #1647. I haven't really followed what's going on there but I must admin I haven't look properly, will do though.

Well, I guess it's really the end of the road for something like this to be accepted. Will just comment one more thing on the parent issue and we can call it/close it if there's really no more work around it to be considered.

@hanoii hanoii closed this Aug 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants