GeoJSON Multipolygon Support #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 27, 2017
Closed
Closed
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
==========================================
+ Coverage 78.59% 78.81% +0.22%
==========================================
Files 47 47
Lines 1551 1553 +2
Branches 111 107 -4
==========================================
+ Hits 1219 1224 +5
+ Misses 332 329 -3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for parsing multipolygons in Magellan by treating a MultiPolygon as a list of polygons and emitting a row per polygon.
Emitting one row per shape allows us to use spatial indexes without having to create a specialized datastructure for Multipolygons whose overhead is heavy.
Multipolygons all share the same properties map.
Client side code that needs to logically regroup this multipolygon for any reason can add / use identifiers in the properties map to regroup the polygons as needed.
This closes issues #30 , #55 , #66