Skip to content

Fix unaccepted network str #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2025
Merged

Fix unaccepted network str #279

merged 1 commit into from
Jul 4, 2025

Conversation

frenck
Copy link
Member

@frenck frenck commented Jul 4, 2025 •
edited by coderabbitai bot
Loading

Proposed Changes

Remove the strict check. The application already checks it, so let's just remove the format check from the add-on

Related Issues

fixes #271

Summary by CodeRabbit

  • Refactor
    • Updated the validation for network entries, allowing any string value for network configuration instead of restricting to specific formats.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jul 4, 2025 •
edited
Loading

Walkthrough

The schema for the networks option in zerotier/config.yaml was updated. The previous regex pattern constraint was removed, and now the field accepts any string, eliminating the previous validation rules that restricted input formats.

Changes

File(s) Change Summary
zerotier/config.yaml Changed networks schema from regex pattern-matching to accept any string type (removed pattern)

Assessment against linked issues

Objective Addressed Explanation
Remove overly restrictive regex validation for networks to allow tokens of any length/format (#271) ✅

Poem

The regex wall is gone, hooray!
Now tokens of all stripes may play.
No more frowns or error screens,
Just simple strings in all routines.
The bunny hops with glee—
Free your configs, regex-free!
🐇✨

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@frenck frenck added the bugfix Inconsistencies or issues which will cause a problem for users or implementors. label Jul 4, 2025
@frenck frenck merged commit 9b90505 into main Jul 4, 2025
22 checks passed
coderabbitai[bot]
coderabbitai bot reviewed Jul 4, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
zerotier/config.yaml (1)

30-32: Relaxing validation may hide user-side typos – consider at least asserting non-empty strings

Dropping the regex makes sense because the backend already validates, but an empty or purely whitespace entry is now accepted and will only fail later at runtime.
A minimal safeguard such as str(min=1) or match(^\S+$) would still catch obvious mistakes without re-introducing the full pattern and keeps the UX tight.

Please double-check that Supervisor still passes !secret xyz values through the generic str rule; previously this was explicitly allowed by the regex. If not, users relying on secrets will break.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ec73e93 and 2a51962.

📒 Files selected for processing (1)
  • zerotier/config.yaml (1 hunks)

@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees
No one assigned
Labels
bugfix Inconsistencies or issues which will cause a problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't setup in HA latest update due to auth_toke not meeting regex
1 participant
@frenck