Skip to content

Reinstante openssl dependencies #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2025
Merged

Reinstante openssl dependencies #273

merged 1 commit into from
May 9, 2025

Conversation

frenck
Copy link
Member

@frenck frenck commented May 9, 2025 •
edited by coderabbitai bot
Loading

Proposed Changes

Re-instantes the openssl dependencies

Related Issues

([Github link][autolink-references] to related issues or pull requests)

fixes #271

Summary by CodeRabbit

  • Chores
    • Updated the Tor addon to include the installation of the latest OpenSSL package for improved security and compatibility.

@frenck frenck added the bugfix Inconsistencies or issues which will cause a problem for users or implementors. label May 9, 2025
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented May 9, 2025 •
edited
Loading

Walkthrough

The Dockerfile for the Tor addon was updated to explicitly install the openssl package (version 3.3.3-r0) during the base setup. This ensures the presence of the openssl binary in the environment, with no other build or dependency changes made.

Changes

File(s) Change Summary
tor/Dockerfile Added installation of openssl=3.3.3-r0 to the package list in the base setup.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Docker Build
    participant Alpine Package Manager
    participant Tor Addon

    User->>Docker Build: Build Tor Addon image
    Docker Build->>Alpine Package Manager: Install tor, openssl, and dependencies
    Alpine Package Manager-->>Docker Build: Packages installed
    Docker Build->>Tor Addon: Image includes openssl binary
Loading

Assessment against linked issues

Objective Addressed Explanation
Ensure openssl is installed so Tor addon can generate certificates and start properly (#271) ✅

Suggested labels

dependencies

Poem

In the Docker warren, a fix hops in,
OpenSSL now joins the spin.
Tor peeks out, no errors found,
Certificates grow from burrowed ground.
With every build, a safer den,
Thanks to a patch from clever pen!
🐇🔒✨

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed May 9, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
tor/Dockerfile (1)

17-21: Refactor for maintainability: extract OpenSSL version into an ARG
Reinstating openssl=3.3.3-r0 ensures the binary and libraries are available at runtime, which addresses issue #271. To simplify future upgrades when the base image is bumped, consider introducing an ARG OPENSSL_VERSION (similar to the other proxies) and referencing it in the apk add command:

+ARG OPENSSL_VERSION=3.3.3-r0
 ...
 RUN \
     apk add --no-cache \
         coreutils=9.5-r2 \
-        openssl=3.3.3-r0 \
+        openssl=${OPENSSL_VERSION} \
         tor=0.4.8.16-r0 \

This makes updating OpenSSL versions more consistent and centralized.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3052eb9 and 010e34d.

📒 Files selected for processing (1)
  • tor/Dockerfile (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: workflows / Build aarch64
  • GitHub Check: workflows / Build armv7
  • GitHub Check: workflows / Build amd64

@frenck frenck merged commit a2c3910 into main May 9, 2025
22 checks passed
@frenck frenck deleted the frenck-2025-0199 branch May 9, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees
No one assigned
Labels
bugfix Inconsistencies or issues which will cause a problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

openssl missing
1 participant
@frenck