Skip to content

Conversation

Anton-Latukha
Copy link
Collaborator

@Anton-Latukha Anton-Latukha commented Dec 30, 2020

What is left is to populate changes introduces in the Implement derivationStrict primOp commit.


Done.

Rendered result.

@Anton-Latukha Anton-Latukha force-pushed the 2020-12-30-release-preparation branch 6 times, most recently from 2e7afd6 to 03a42bf Compare January 1, 2021 23:53
@Anton-Latukha Anton-Latukha mentioned this pull request Jan 2, 2021
@Anton-Latukha Anton-Latukha force-pushed the 2020-12-30-release-preparation branch 2 times, most recently from df55458 to 38e5aa0 Compare January 2, 2021 01:19
@Anton-Latukha
Copy link
Collaborator Author

Anton-Latukha commented Jan 4, 2021

That took a while to parse.

After all - there are not so many API changes I expected, but there are quite a few.
Most of the work was done in the new module after all.

@Anton-Latukha Anton-Latukha force-pushed the 2020-12-30-release-preparation branch 3 times, most recently from 6e55a64 to 08f3e51 Compare January 4, 2021 18:01
@Anton-Latukha Anton-Latukha force-pushed the 2020-12-30-release-preparation branch from 08f3e51 to 712638a Compare January 4, 2021 19:47
@Anton-Latukha Anton-Latukha marked this pull request as ready for review January 4, 2021 19:47
@Anton-Latukha Anton-Latukha merged commit fb7ff92 into master Jan 4, 2021
@Anton-Latukha Anton-Latukha deleted the 2020-12-30-release-preparation branch January 4, 2021 19:51
@layus
Copy link
Collaborator

layus commented Jan 4, 2021

Hi,

Thanks for the updates. I would like to make two additions to the release note:

  1. Add a warning that most of the public API is there only by accident, and is not to be relied upon.
  2. Add a top-level note saying that derivationStrict, and hence every evaluation of a derivation into a store path relies on hnix-store-remote, which means implicitly that it relies on a running nix daemon and will make changes in the real nix store behind.

@layus
Copy link
Collaborator

layus commented Jan 4, 2021

The first warning would also simplify the work of providing release notes.

For example, my move to Nix/Effects/Derivation.hs was only meant to separate relatively unrelated code and collect derivation-related functions in a single place. I do not think these functions should be part of any kind of API.

@Anton-Latukha
Copy link
Collaborator Author

Anton-Latukha commented Jan 4, 2021

Yep.

Thank you for the note.

Team (probably means I) need to bite the bullet and move the modules to the Internal structure, aka superfluously just graf-lift everything as a preparation phase to the clean-up. So when we clean-up the public interface - we would have distinguished private internal interfaces and public ones and form them properly.

@Anton-Latukha
Copy link
Collaborator Author

The note that derivationStrict is effectful and how is definitely a must be top.

@Anton-Latukha Anton-Latukha mentioned this pull request Jan 4, 2021
@Anton-Latukha
Copy link
Collaborator Author

I think the same disclaimer probably needs to be in the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace all occurrences of hackyStringMappend with principled... versions.
2 participants