Skip to content

Add makeFixedOutputPath #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 28, 2020
Merged

Add makeFixedOutputPath #36

merged 2 commits into from
Mar 28, 2020

Conversation

puffnfresh
Copy link
Member

No description provided.

shlevy
shlevy requested changes Mar 15, 2019
View reviewed changes
Copy link
Member

@shlevy shlevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, clicked too early... Why do we special case this to SHA256? Also on master digestText16 is no longer in the Hash module, though maybe we should move it here (though probably needs a different name).

@puffnfresh puffnfresh force-pushed the makeFixedOutputPath branch from 3b5cc3a to 8325f24 Compare March 24, 2019 16:23
@puffnfresh
Copy link
Member Author

Why do we special case this to SHA256?

At the moment makeStorePath is special cased to SHA256, which the function uses.

I've fixed the digest problem. Seems to be working.

@shlevy
Copy link
Member

shlevy commented Mar 24, 2019

Ah can you rebase on/merge in #42 ?

@puffnfresh puffnfresh force-pushed the makeFixedOutputPath branch from 8325f24 to 1d6a1ae Compare March 25, 2019 11:11
@puffnfresh puffnfresh requested a review from shlevy April 3, 2019 02:18
shlevy
shlevy reviewed Apr 3, 2019
View reviewed changes
@puffnfresh puffnfresh force-pushed the makeFixedOutputPath branch from 1d6a1ae to c02177d Compare June 25, 2019 16:44
@puffnfresh puffnfresh requested a review from shlevy June 25, 2019 16:49
@sorki sorki mentioned this pull request Mar 5, 2020
Merged
@Ericson2314
Copy link
Member

We should add something about the references that are unstable in Nix, but this looks good to me.

@Ericson2314 Ericson2314 merged commit 46cf3fc into haskell-nix:master Mar 28, 2020
@sorki sorki mentioned this pull request Jul 27, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlevy shlevy shlevy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@puffnfresh @shlevy @Ericson2314