Skip to content

Base16/Base32 decoding, props/tests #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 22, 2020
Merged

Base16/Base32 decoding, props/tests #57

merged 2 commits into from
Mar 22, 2020

Conversation

sorki
Copy link
Member

@sorki sorki commented Mar 4, 2020

Moves Nix-en/decoding code to Internal.Base32, adds more tests and arbitrary instances.

This was referenced Mar 4, 2020
Closed
Merged
imalsogreg
imalsogreg approved these changes Mar 22, 2020
View reviewed changes
Copy link
Collaborator

@imalsogreg imalsogreg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have these tests!
I ran the test suite locally. Looks good.

@imalsogreg imalsogreg merged commit 7e61a7c into haskell-nix:master Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imalsogreg imalsogreg imalsogreg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sorki @imalsogreg