Skip to content

Conversation

lbajolet-hashicorp
Copy link
Contributor

Sicne the current docs do not show the SMP or EFI configuration attributes on devdot, we add sections to the main builder page to show those configuration attributes.

@lbajolet-hashicorp lbajolet-hashicorp requested a review from a team as a code owner April 27, 2023 14:16
@lbajolet-hashicorp lbajolet-hashicorp added the documentation Improvements or additions to documentation label Apr 27, 2023
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sicne the current docs do not show the SMP or EFI configuration
attributes on devdot, we add sections to the main builder page to show
those configuration attributes.
For the firmware arguments, we mentioned in the docs that the `efi_'
arguments were preferred in EFI mode, but did not provide a clean link
to them.

This commit fixes that problem.
@lbajolet-hashicorp lbajolet-hashicorp merged commit 5b837b6 into main Apr 27, 2023
@lbajolet-hashicorp lbajolet-hashicorp deleted the fix_docs_refs branch April 27, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants