Skip to content

Add plugin binaries for illumos distribution #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2023
Merged

Add plugin binaries for illumos distribution #127

merged 1 commit into from
Apr 28, 2023

Conversation

jperkin
Copy link
Contributor

@jperkin jperkin commented Feb 22, 2023

This hopefully results in illumos binaries being made available, currently the experience is:

$ packer init -upgrade .
Failed getting the "github.com/hashicorp/qemu" plugin:
58 errors occurred:
        * ignoring invalid remote binary packer-plugin-qemu_v1.0.9_x5.0_linux_amd64.zip: wrong system, expected illumos_amd64 
[...]
        * could not install any compatible version of plugin "github.com/hashicorp/qemu"

Many thanks.

@jperkin jperkin requested a review from a team as a code owner February 22, 2023 12:25
@hashicorp-cla
Copy link

hashicorp-cla commented Feb 22, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@nywilken
Copy link
Contributor

Hi @jperkin, same issue here with the conflict. Sorry this was changed underneath you. Do you mind rebasing please.

nywilken
nywilken approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As stated for Ansible I am adding the binary with the expectations that it is not officially part of the supported binaries for Packer releases. Which means if in the future we find that we can not continue to maintain the binary because of testing reasons it will be removed.

@jperkin
Copy link
Contributor Author

jperkin commented Apr 28, 2023

Done, thanks!

@nywilken nywilken merged commit da67715 into hashicorp:main Apr 28, 2023
@nywilken nywilken changed the title Build plugin for illumos. Add plugin binaries for illumos distribution Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@nywilken nywilken nywilken approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jperkin @hashicorp-cla @nywilken