Skip to content

example: update EFI build example with build_steps #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 24, 2023
Merged

example: update EFI build example with build_steps #117

merged 2 commits into from
Jan 24, 2023

Conversation

lbajolet-hashicorp
Copy link
Contributor

Since we added the build_steps alternative for documenting and adding the boot commands, we update the example so it shows how it is used.

@lbajolet-hashicorp
example: update EFI build example with build_steps
dd8d191 
Since we added the build_steps alternative for documenting and adding
the boot commands, we update the example so it shows how it is used.
@lbajolet-hashicorp lbajolet-hashicorp requested a review from a team as a code owner January 23, 2023 19:54
@lbajolet-hashicorp lbajolet-hashicorp added the documentation Improvements or additions to documentation label Jan 23, 2023
sylviamoss
sylviamoss approved these changes Jan 24, 2023
View reviewed changes
Copy link

@sylviamoss sylviamoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! LGTM 👍🏼

nywilken
nywilken reviewed Jan 24, 2023
View reviewed changes
nywilken
nywilken approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Call ✅ I left one suggestion but this otherwise LGTM.

@lbajolet-hashicorp @nywilken
Update example/efi_build/efi-debian.pkr.hcl
7275986 
Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
@lbajolet-hashicorp lbajolet-hashicorp merged commit 84b2478 into main Jan 24, 2023
@lbajolet-hashicorp lbajolet-hashicorp deleted the example_boot_steps branch January 24, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@nywilken nywilken nywilken approved these changes

@sylviamoss sylviamoss sylviamoss approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lbajolet-hashicorp @nywilken @sylviamoss