Skip to content

Conversation

lbajolet-hashicorp
Copy link
Contributor

Contrary to the original intent, the efivars.fd file that contains the required keys and EFI entries was removed all the time, including when the build was successful.

This is an error, and is therefore fixed with this commit.

Closes #115

@lbajolet-hashicorp lbajolet-hashicorp requested a review from a team as a code owner January 23, 2023 19:53
@lbajolet-hashicorp lbajolet-hashicorp changed the title builer: only remove efivars on failure builder: only remove efivars on failure Jan 23, 2023
Contrary to the original intent, the efivars.fd file that contains the
required keys and EFI entries was removed all the time, including when
the build was successful.

This is an error, and is therefore fixed with this commit.
Copy link

@sylviamoss sylviamoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 LGTM!

Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbajolet-hashicorp lbajolet-hashicorp merged commit 14e8d4e into main Jan 24, 2023
@lbajolet-hashicorp lbajolet-hashicorp deleted the fix_efivars_output branch January 24, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EFI step deletes "efivars.fd" required for booting VM
3 participants