CPU model option #114
Merged
CPU model option #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CPU model is a qemu setting that lets users change the default cpu model used for building their VM image. On some Linux distributions (RHEL9), the default value for x86-64 hosts and guests (qemu64) is unsupported, leading to the plugin failing to start a VM. To make it easier for these users to user Packer with qemu, we add this option to the configurations, so they can specify it. This also allows us to document the potential problem they will encounter, and suggest a workaround if/when it arises.
sylviamoss
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the RHEL9 panic issue linked to this PR, this PR is an attempt to make it easier for users of Packer/qemu on RHEL9+ hosts to set the CPU model for their builds.
Since
qemu64(the default value) is not supported anymore on such hosts, we add this option to make it easier for those users to set a supported value. This also gives us a good opportunity to document the kind of workaround necessary to make a build work in such an environment.When the value is not set, the option is not automatically added (we can maybe discuss this part, @nywilken, what do you think?).
Closes: #76