ops: handle unknown objects correctly when looking up by index #763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
137a079 to
b77b463
Compare
jbardin
approved these changes
Jul 3, 2025
There was a problem hiding this comment.
LGTM!
There seems to be a subtle change in behavior here, where an index could be used on an object to avoid this validation. If for example you have an unknown object with only a foo attribute,
try(object["bar"], true)
In Terraform this would change the evaluation from a dynamic unknown to true, but since resolving an unknown of type any to a bool is valid, I can't come up with any way this could cause failures in existing config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The linked bug relates to an issue in Terraform where the static checking of objects isn't working as expected. The reason is that objects are converted to unknown values, and then references are walked using the Index function in this repo.
The index function was previously just not validating the requested index at all and returning the object unchanged. For objects we do actually know the attributes even if it is unknown, so we can still validate the index and return an unknown value of the correct type if the index does actually exist.
This fixes the underlying bug in Terraform, since the invalid references will now be properly type checked.
Related Issue
hashicorp/terraform#37271
How Has This Been Tested?
Unit tested