Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: hashicorp/go-getter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.2.2
Choose a base ref
...
head repository: hashicorp/go-getter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.2.3
Choose a head ref
  • 3 commits
  • 7 files changed
  • 1 contributor

Commits on May 20, 2024

  1. Configuration menu
    Copy the full SHA
    e51bb20 View commit details
    Browse the repository at this point in the history
  2. [v2] Update cmd/go-getter to use that latest versions of go-getter/v2 (

    …#490)
    
    * Bumps go-getter/v2 module along with go-getter/gcs/v2 and go-getter/s3/v2
    nywilken authored May 20, 2024
    Configuration menu
    Copy the full SHA
    e310de3 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Backport fix from #497 to v2 (#498)

    * Recreate git config during update to prevent git config alteration
    
    Backport fix from #497 to v2
    
    * Bump version of Golang container to match module version
    
    The Go module for v2 is 1.19, bumping the base docker image to match the
    minimum version ensures go-getter can be compiled and executed on the
    container. This change resolves the failing acceptance test for Samba.
    
    ```
    Run docker exec -i gogetter bash -c "env ACC_SMB_TEST=1 go test -v ./... -run=TestSmb_"
      docker exec -i gogetter bash -c "env ACC_SMB_TEST=1 go test -v ./... -run=TestSmb_"
      shell: /usr/bin/bash -e {0}
      env:
        TEST_RESULTS_PATH: /tmp/test-results
    Error: ./get_git.go:366:16: undefined: os.ReadDir
    Error: ./get_git_test.go:886:9: undefined: os.WriteFile
    Error: ./get_git_test.go:904:22: undefined: os.ReadFile
    note: module requires Go 1.19
    FAIL	github.com/hashicorp/go-getter/v2 [build failed]
    ?   	github.com/hashicorp/go-getter/v2/helper/testing	[no test files]
    testing: warning: no tests to run
    PASS
    ok  	github.com/hashicorp/go-getter/v2/helper/url	0.006s [no tests to run]
    FAIL
    Error: Process completed with exit code 2.
    
    ```
    nywilken authored Jul 23, 2024
    Configuration menu
    Copy the full SHA
    dc7f6bc View commit details
    Browse the repository at this point in the history
Loading