Upgrade go-msgpack to v2 2.1.1 #19313
Conversation
This is mostly a no-op for Consul as Consul mostly uses `consul-net-rpc` and the default `time.Time` encoding for go-msgpack 2.1.1 is set to the go-msgpack-0.5.5-compatible encoding by default, so no changes should be necessary in code. go-msgpack 2.1.1 was specifically designed to honor backwards compatibility with 1.1.5 and 0.5.5, and to clean up the code base to be more maintainable. See [the release notes for go-msgkack 2.1.0](https://github.com/hashicorp/go-msgpack/releases/tag/v2.1.0) for more details. I tested this by running this code, and booting up a cluster with a node also running the prior version of Consul (before the upgrade). The node came up smoothly, even after changing leadership between them. This relies on - [ ] hashicorp/serf#705 - [ ] hashicorp/raft-boltdb#38 - [ ] hashicorp/raft#577 - [ ] hashicorp/memberlist#292 and will need to be updated after they are merged to get the `go.mod` fixes removed.
|
This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions. |
|
This is still relevant, and I'm happy to do any follow-up required. |
|
This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions. |
|
Closing due to inactivity. If you feel this was a mistake or you wish to re-open at any time in the future, please leave a comment and it will be re-surfaced for the maintainers to review. |
This is mostly a no-op for Consul as Consul mostly uses
consul-net-rpcand the defaulttime.Timeencoding for go-msgpack 2.1.1 is set to the go-msgpack-0.5.5-compatible encoding by default, so no changes should be necessary in code.go-msgpack 2.1.1 was specifically designed to honor backwards compatibility with 1.1.5 and 0.5.5, and to clean up the code base to be more maintainable. See
the release notes for go-msgkack 2.1.0 for more details.
I tested this by running this code, and booting up a cluster with a node also running the prior version of Consul (before the upgrade). The node came up smoothly, even after changing leadership between them.
This relies on
and will need to be updated after they are merged to get the
go.modfixes removed.PR Checklist