Skip to content

Conversation

hashi-derek
Copy link
Contributor

Manual backport of #19339

@github-actions github-actions bot added type/docs Documentation needs to be created/updated/clarified theme/config Relating to Consul Agent configuration, including reloading labels Oct 24, 2023
@hashi-derek hashi-derek added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport labels Oct 24, 2023
Prior to the introduction of this configuration, grpc keepalive messages were
sent after 2 hours of inactivity on the stream. This posed issues in various
scenarios where the server-side xds connection balancing was unaware that envoy
instances were uncleanly killed / force-closed, since the connections would
only be cleaned up after ~5 minutes of TCP timeouts occurred. Setting this
config to a 30 second interval with a 20 second timeout ensures that at most,
it should take up to 50 seconds for a dead xds connection to be closed.
@hashi-derek hashi-derek force-pushed the derekm/grpc-server-keepalive-1.17.x branch from c8ab4a5 to fdd2fe1 Compare October 24, 2023 13:21
@hashi-derek hashi-derek marked this pull request as ready for review October 24, 2023 13:46
@hashi-derek hashi-derek requested review from a team as code owners October 24, 2023 13:46
@hashi-derek hashi-derek merged commit 8b35e08 into release/1.17.x Oct 24, 2023
@hashi-derek hashi-derek deleted the derekm/grpc-server-keepalive-1.17.x branch October 24, 2023 13:51
@hashi-derek hashi-derek changed the title Backport of Add grpc keepalive configuration (#19339) to 1.17.x [NET-6295] Backport of Add grpc keepalive configuration (#19339) to 1.17.x Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry theme/config Relating to Consul Agent configuration, including reloading type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants