Skip to content

centralize useV2Resources logic in deps and use that to configure server #19132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2023
Merged

centralize useV2Resources logic in deps and use that to configure server #19132

merged 1 commit into from
Oct 10, 2023

Conversation

jmurret
Copy link
Member

@jmurret jmurret commented Oct 10, 2023

Description

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@jmurret jmurret added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport labels Oct 10, 2023
@jmurret jmurret requested a review from rboyer October 10, 2023 22:24
@jmurret jmurret requested a review from a team as a code owner October 10, 2023 22:24
@rboyer
Copy link
Member

rboyer commented Oct 10, 2023

This is like a really big "suggested changes" comment. 👍

@jmurret jmurret mentioned this pull request Oct 10, 2023
Merged
@jmurret jmurret merged commit 408e9a1 into rboyer/reject-v1-catalog Oct 10, 2023
@jmurret jmurret deleted the jm/rej-v1-cat branch October 10, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rboyer rboyer rboyer approved these changes

Assignees
No one assigned
Labels
pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmurret @rboyer