Skip to content

[NET-5788] Fix needed for JWTAuth in Consul Enterprise #19038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2023
Merged

[NET-5788] Fix needed for JWTAuth in Consul Enterprise #19038

merged 1 commit into from
Oct 3, 2023

Conversation

sarahalsmiller
Copy link
Member

Description

To match changes made in consul enterprise in this PR https://github.com/hashicorp/consul-enterprise/pull/7209

Testing & Reproduction steps

  • No behavior should change with this PR, all tests should continue to passing as expected

PR Checklist

  • updated test coverage
  • external facing docs updated
  • [ X ] appropriate backport labels added
  • [ X ] not a security concern

@sarahalsmiller sarahalsmiller added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport labels Oct 2, 2023
@github-actions github-actions bot added the theme/envoy/xds Related to Envoy support label Oct 2, 2023
jm96441n
jm96441n approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@jm96441n jm96441n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sarahalsmiller sarahalsmiller merged commit 9addd9e into main Oct 3, 2023
@sarahalsmiller sarahalsmiller deleted the NET-5788-fix-ready-listeners-in-core branch October 3, 2023 14:48
sarahalsmiller added a commit that referenced this pull request Oct 6, 2023
@sarahalsmiller
Revert "[NET-5788] Fix needed for JWTAuth in Consul Enterprise (#19038)"
06f116a 
This reverts commit 9addd9e.
@sarahalsmiller sarahalsmiller mentioned this pull request Oct 6, 2023
Closed
@nathancoleman nathancoleman mentioned this pull request Oct 17, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jm96441n jm96441n jm96441n approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry theme/envoy/xds Related to Envoy support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarahalsmiller @jm96441n