deps: update gopsutil to fix Windows ARM and macOS non-Apple LLVM builds #11586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4d49c1e to
52826ad
Compare
52826ad to
2149cee
Compare
|
@mikemorris was this just basically: |
rboyer
approved these changes
Nov 16, 2021
Bumps transitive dep go-ole to v1.2.6 with fixes
2149cee to
3dea9e9
Compare
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/504160. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps transitive dep https://github.com/go-ole/go-ole to v1.2.6 with fixes for
windows/armandwindows/arm64builds.Resolves below warning when running
make lintRefs shirou/gopsutil#1181 for additional detail on a non-blocking upstream transitive dependency update.
Also resolves shirou/gopsutil#976 when attempting to compile on macOS with a non-Apple LLVM (such as installed via Homebrew). This error can be hit when running
go buildorgo testdirectly rather than via the Makefile.