Skip to content

Conversation

DanStough
Copy link
Contributor

Always publishing full and minor-only tag versions. This accomplishes two goals:

  1. For long running release branches, .x, always publish a minor-only tag so that tests use the latest version (e.g. 1.4-dev)
  2. For point release branches, .0, always publish the full version so we can fix this for testing purposes (e.g. 1.3.0)

@DanStough DanStough requested review from curtbushko, zalimeni, a team, shore and jeanneryan and removed request for a team October 18, 2023 14:55
@DanStough DanStough added backport/1.1 Changes are backported to 1.1 backport/1.2 labels Oct 18, 2023
@DanStough
Copy link
Contributor Author

I expect the backports to fail but at least they will be a starting point.

@DanStough DanStough added the pr/no-changelog This PR does not introduce a user-facing change that should be reflected in the changelog label Oct 18, 2023
@DanStough DanStough force-pushed the dans/fix-docker-dev-tag branch from 1c07739 to 0c340e1 Compare October 18, 2023 15:00
Copy link
Member

@zalimeni zalimeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!!

Copy link
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanStough DanStough force-pushed the dans/fix-docker-dev-tag branch from 0c340e1 to 52c14b7 Compare October 18, 2023 16:42
@DanStough
Copy link
Contributor Author

Backport assistant died. . Going in manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.1 Changes are backported to 1.1 pr/no-changelog This PR does not introduce a user-facing change that should be reflected in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants