Skip to content

Switch output loggers in hclog instead of going through gatedlogger #8228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2020
Merged

Switch output loggers in hclog instead of going through gatedlogger #8228

merged 1 commit into from
Feb 15, 2020

Conversation

jefferai
Copy link
Member

After flushing we no longer have to take a mutex hit for every log line.

@jefferai
Switch output loggers in hclog instead of going through gatedlogger
c131bb6 
After flushing we no longer have to take a mutex hit for every log line.
@jefferai jefferai added this to the 1.4 milestone Jan 23, 2020
calvn
calvn approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@calvn calvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

calvn
calvn reviewed Jan 23, 2020
View reviewed changes
@briankassouf briankassouf merged commit 4bf92f2 into master Feb 15, 2020
@briankassouf briankassouf deleted the update-logger-new-hclog branch February 15, 2020 01:50
@elliesterner elliesterner mentioned this pull request Mar 13, 2025
Merged
6 tasks
This was referenced Mar 13, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@calvn calvn calvn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@jefferai @calvn @briankassouf