Skip to content

Conversation

elliesterner
Copy link
Contributor

@elliesterner elliesterner commented Mar 28, 2025

Description

This change reintroduces the UpsertGroup RPC functionality for use by the refreshExternalGroupMembershipsByEntityID function. Users were unable to log in or renew their tokens if their entity's external group association changed. This issue stemmed from performance standby nodes being unable to write group updates to storage. To fix this regression, we’ve restored the RPC functionality, allowing performance standbys to forward group update logic to the active node.

ENT PR: https://github.com/hashicorp/vault-enterprise/pull/7716

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@elliesterner elliesterner requested a review from a team as a code owner March 28, 2025 00:18
@elliesterner elliesterner requested a review from paymanblu March 28, 2025 00:18
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Mar 28, 2025
Copy link

github-actions bot commented Mar 28, 2025

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Mar 28, 2025

Build Results:
All builds succeeded! ✅

@elliesterner elliesterner added this to the 1.19.1 milestone Mar 28, 2025
biazmoreira
biazmoreira previously approved these changes Mar 28, 2025
@elliesterner elliesterner merged commit b95351a into main Mar 28, 2025
92 checks passed
@elliesterner elliesterner deleted the elliesterner/perf-standby-group-upsert-fix-ce branch March 28, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants