Allow Root + Intermediate Key_Usage to be set #30034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Results: |
|
Build Results: |
stevendpclark
requested changes
Mar 26, 2025
There was a problem hiding this comment.
I'd rather we follow the CAB forum guidelines section 7.1.2.10.7 and limit CA key_usages to just digitalSignature, keyCertSign and cRLSign.
Can we add a check within the root generate and sign-intermediate paths to error out if we are provided any key usage value outside of those , along with updating the relevant docs?
…low DigitalSignature.
514a09d to
32bd832
Compare
stevendpclark
previously approved these changes
Mar 28, 2025
schavis
requested changes
Apr 3, 2025
Style correction suggested by Sarah Chavis. Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
schavis
approved these changes
Apr 3, 2025
stevendpclark
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows Root and Intermediate Key_Usage to be set via CLI, not just in the CSR
Fixes: #29362
The test here doesn't successfully fail on a bad branch, so this is a draft right now.
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.