Skip to content

Conversation

kubawi
Copy link
Contributor

@kubawi kubawi commented Mar 20, 2025

Description

This PR updates the hashicorp/raft library version from 1.7.1 to 1.7.3 to add extra logging on a leader node when it opens and sends a snapshot to a follower. We are doing this in order to make debugging and supporting Vault easier.

Full changes here: hashicorp/raft@v1.7.1...v1.7.3

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

… leader node when opening and sending a raft snapshot to a follower
@kubawi kubawi added this to the 1.19.1 milestone Mar 20, 2025
@kubawi kubawi self-assigned this Mar 20, 2025
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Mar 20, 2025
Copy link

github-actions bot commented Mar 20, 2025

CI Results:
All Go tests succeeded! ✅

@kubawi kubawi added dependencies Pull requests that update a dependency file storage/raft labels Mar 21, 2025
@kubawi kubawi marked this pull request as ready for review March 21, 2025 12:43
@kubawi kubawi requested a review from a team as a code owner March 21, 2025 12:43
Copy link

Build Results:
All builds succeeded! ✅

@kubawi kubawi merged commit e1094e5 into main Mar 21, 2025
109 of 135 checks passed
@kubawi kubawi deleted the kubawi/VAULT-29278/update-raft-lib-to-add-logging-on-active-node-when-sending-snapshot branch March 21, 2025 13:20
@kwagga
Copy link
Contributor

kwagga commented Jul 21, 2025

Thanks for sharing the upstream change. This is extremely helpful for support!

hashicorp/raft@v1.7.1...v1.7.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed storage/raft
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants