Skip to content

Conversation

lane-wetmore
Copy link
Contributor

@lane-wetmore lane-wetmore commented Mar 3, 2025

Description

This PR refactors the current sidebranch work to align with newer Ember patterns in preparation for design updates.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@lane-wetmore lane-wetmore added the ui label Mar 3, 2025
@lane-wetmore lane-wetmore added this to the 1.20.0-rc milestone Mar 3, 2025
@lane-wetmore lane-wetmore self-assigned this Mar 3, 2025
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Mar 3, 2025
Copy link

github-actions bot commented Mar 3, 2025

CI Results:
All Go tests succeeded! ✅

@lane-wetmore lane-wetmore marked this pull request as ready for review March 5, 2025 16:29
@lane-wetmore lane-wetmore requested a review from a team as a code owner March 5, 2025 16:29
Copy link

github-actions bot commented Mar 5, 2025

Build Results:
All builds succeeded! ✅

@lane-wetmore lane-wetmore changed the title DRAFT: UI/vault 34066 refactor newer patterns UI/vault 34066 refactor newer patterns Mar 5, 2025
@lane-wetmore lane-wetmore changed the title UI/vault 34066 refactor newer patterns UI: Refactor to newer patterns Mar 5, 2025
Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! This is awesome progress. Left some comments with some ember data/routing suggestions. I'll do another pass once those are addressed 😄

Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com>
Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Some suggestions on refactoring some of the model logic. We can refactor that later since I think this is a great first pass. But before merging, could we address the small cleanup items like removing unused methods and adding "to do" comments?

Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work and really great progress. I think we're good to merge once that acceptance test is passing! Left some more consolidation suggestions but those can wait for the next iteration 😄

@lane-wetmore lane-wetmore merged commit 0537b03 into ui-totp-sidebranch Mar 7, 2025
25 checks passed
@lane-wetmore lane-wetmore deleted the ui/VAULT-34066-refactor-newer-patterns branch March 7, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants