VAULT-191: Validate X-Forwarded-For IP #29774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Results: |
bosouza
approved these changes
Feb 28, 2025
|
Build Results: |
raskchanky
approved these changes
Mar 4, 2025
This was referenced Mar 4, 2025
Jonher937
reviewed
Apr 22, 2025
| req := client.NewRequest("GET", "/") | ||
| req.Headers = make(http.Header) | ||
| req.Headers.Set("x-forwarded-for", "5.6.7.8, 4.5.6.7, 8.8.8.8") | ||
| req.Headers.Set("x-forwarded-for", "10.9.8.7, 1.2.3.4, 256.1.1.1") |
There was a problem hiding this comment.
@miagilepner calling .Set() will replace the contents.
https://pkg.go.dev/net/http#Header.Set
You'd want to use https://pkg.go.dev/net/http#Header.Add if the intention was to test two chains of x-fowarded-for.
The same issue exists in the second testcase you added below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR validates that the client address extracted from the X-Forwarded-For header is a valid IP address
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.