UI/managed namespace changes #10588
Merged
UI/managed namespace changes #10588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce without permission
…ion call to vault-config endpoint (mocked)
… managed root namespace set
Monkeychip
reviewed
Dec 16, 2020
Monkeychip
reviewed
Dec 16, 2020
Monkeychip
reviewed
Dec 16, 2020
ui/app/services/config.js
Outdated
| @@ -0,0 +1,9 @@ | |||
| import Service from '@ember/service'; | |||
|
|
|||
| export default Service.extend({ | |||
There was a problem hiding this comment.
With octane you should be able to start writing these as Native classes (however, ignore me if we have to backport to prior to 1.7).
ex:
import Service from '@ember/service';
export default class ShoppingCartService extends Service {
}
There was a problem hiding this comment.
Great catch, however we do indeed have to backport this to prior to 1.7 😭
…or feature-flags on shamir test
chelshaw
commented
Jan 7, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes include:
When a root namespace is retrieved from endpoint and no namespace param is present, redirect:
