switch to ergochat/readline #33305
Draft
switch to ergochat/readline #33305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for this submission! To set expectations, we will need to have this reviewed by the security team and we are in the beta/RC period for 1.5 so it may be some time before this is reviewed. Thanks again! |
|
Just wanted to check in about this again? |
|
Thanks for the bump. I'll bring it up in triage again, to see if we want to pursue this in the near future. |
|
(Updating to our latest release, v0.1.0) |
|
Thanks for this. We are going to work on a process for updating dependencies before new releases. I'll keep you posted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the Terraform console library from chzyer/readline, which is unmaintained, to a fork ergochat/readline, maintained by me and @wader.
This will fix a number of bugs, including #33195. It may also make possible Solaris support for the console, which is currently compiled out:
terraform/internal/command/console_interactive_solaris.go
Lines 18 to 20 in c42e0ee
I can confirm that our fork builds with
GOOS=solaris, but I don't have a Solaris environment to confirm that the runtime behavior is as expected.Fixes #33195
Target Release
1.5.x
Draft CHANGELOG entry
BUG FIXES
terraform console: Fixed crash from Ctrl-C when searching an empty history