Skip to content

Walk hierarchy asynchronously #188

New issue
New issue
Closed
#196
Closed
Walk hierarchy asynchronously#188
#196
Labels
enhancementNew feature or request
Milestone
v0.5.0
@radeksimko

Description

@radeksimko
radeksimko
opened on Jun 25, 2020

Current Version

v0.4.0

Use-cases

Currently the whole hierarchy is walked through to discover root modules on initialization synchronously:

terraform-ls/langserver/handlers/initialize.go

Lines 58 to 66 in e40f7c5

walker := rootmodule.NewWalker()
walker.SetLogger(lh.logger)
err = walker.WalkInitializedRootModules(fh.Dir(), func(dir string) error {
lh.logger.Printf("Adding root module (via %T): %s", rmm, dir)
return rmm.AddRootModule(dir)
})
if err != nil {
return serverCaps, err
}

This can result in:

  1. delay in adding paths to the watcher
  2. delayed initial response to the client, which means the client may refuse to provide any functionality until initialize request is responded to

Proposal

Run walker asynchronously.

It should still be cancellable per session though.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions