Skip to content

Avoid simplifying mod-by-zero #4048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2019
Merged

Avoid simplifying mod-by-zero #4048

merged 1 commit into from
Jul 24, 2019

Conversation

abadams
Copy link
Member

@abadams abadams commented Jul 23, 2019

Fixes #4047

Same problem as the last div fix. We were simplifying 0 % 0 to 0.

steven-johnson
steven-johnson approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@steven-johnson steven-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green

@steven-johnson
Copy link
Contributor

mingw failure appears to be #4001

@abadams
Copy link
Member Author

abadams commented Jul 24, 2019

and linux is failing due to the sort issue. Merging.

@abadams abadams merged commit c15adfa into master Jul 24, 2019
@abadams abadams deleted the fix_4047 branch July 24, 2019 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steven-johnson steven-johnson steven-johnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fuzz_simplify failure
2 participants
@abadams @steven-johnson