Skip to content

HALIDE_VERSION_MAJOR/HALIDE_SERIALIZATION_VERSION_MAJOR etc should be defined in headers, not build files #7980

@steven-johnson

Description

@steven-johnson

Definiing in Makefile (etc) makes it easy for values to go stale between build systems, especially when migrating to downstream build systems. I can't think of any reason not to define this in source code, which will be the same between all versions of builds, am I missing something?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions