Skip to content

docs: update readme for umami CORS and CSP #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 5, 2022
Merged

docs: update readme for umami CORS and CSP #4

merged 2 commits into from
Dec 5, 2022

Conversation

chy9002
Copy link
Contributor

@chy9002 chy9002 commented Dec 1, 2022 •
edited by ruibaby
Loading

close #3

none

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Dec 1, 2022
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and ruibaby December 1, 2022 13:38
ruibaby
ruibaby requested changes Dec 2, 2022
View reviewed changes
@ruibaby ruibaby changed the title 增加FAQ，反代时CORS和CSP错误处理方法. docs: update readme for umami CORS and CSP Dec 2, 2022
ruibaby
ruibaby approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2022
ruibaby
ruibaby reviewed Dec 5, 2022
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 5, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit b87c10c into halo-sigs:main Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruibaby ruibaby ruibaby approved these changes

@JohnNiang JohnNiang Awaiting requested review from JohnNiang

Assignees

@ruibaby ruibaby

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

若Umami使用nginx反代, 可能会无法正常使用
2 participants
@chy9002 @ruibaby