Skip to content

Conversation

guqing
Copy link
Member

@guqing guqing commented Jul 5, 2023

What type of PR is this?

/kind improvement

What this PR does / why we need it:

优化项目基础设施配置

Which issue(s) this PR fixes:

Fixes #32

Does this PR introduce a user-facing change?

优化项目基础设施配置

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 5, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and ruibaby July 5, 2023 08:54
@guqing guqing requested a review from ruibaby July 6, 2023 02:51
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jul 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2023
@ruibaby
Copy link
Member

ruibaby commented Jul 9, 2023

修改了 workflow 导致无法自动合并,我将手动合并此 PR。

@ruibaby ruibaby merged commit bc32e92 into halo-sigs:main Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

优化项目基础架构
2 participants