Skip to content

fix: link management permission was assigned but still did not have permission #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2023
Merged

fix: link management permission was assigned but still did not have permission #15

merged 1 commit into from
Feb 17, 2023

Conversation

guqing
Copy link
Member

@guqing guqing commented Feb 16, 2023

What this PR does?

修复分配了友链管理权限仍无权限访问的问题
/kind improvement

/cc @halo-sigs/halo

how to test it?

  1. 在此 PR 构建插件安装
  2. 新建一个角色分配链接查看/管理权限，期望能正确获取到友链分组和友链
修复给角色分配友链管理权限仍无权限访问的问题

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 16, 2023

@guqing: GitHub didn't allow me to request PR reviews from the following users: halo-sigs/halo.

Note that only halo-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What this PR does?

修复分配了友链管理权限仍无权限访问的问题
/kind improvement

/cc @halo-sigs/halo

how to test it?

  1. 在此 PR 构建插件安装
  2. 新建一个角色分配链接查看/管理权限，期望能正确获取到友链分组和友链
修复给角色分配友链管理权限仍无权限访问的问题

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Feb 16, 2023
JohnNiang
JohnNiang approved these changes Feb 16, 2023
View reviewed changes
Copy link
Collaborator

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2023
ruibaby
ruibaby reviewed Feb 17, 2023
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 65168eb into halo-sigs:main Feb 17, 2023
@guqing guqing deleted the refactor/9 branch March 2, 2023 02:45
@guqing guqing mentioned this pull request Mar 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruibaby ruibaby ruibaby left review comments

@JohnNiang JohnNiang JohnNiang approved these changes

Assignees

@ruibaby ruibaby

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guqing @JohnNiang @ruibaby