Skip to content

feat: adapt to the comment plugin #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 13, 2024
Merged

feat: adapt to the comment plugin #66

merged 3 commits into from
Jun 13, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Jun 13, 2024 •
edited by ruibaby
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

为友链页面适配评论插件。在当前的 links.html 模板下，增加如下 HTML 即可为友链页面增加评论组件。

<div th:if="${haloCommentEnabled}">
    <halo:comment
        group="plugin.halo.run"
        kind="Plugin"
        th:attr="name=${pluginName}"
    />
</div>

提交后将在评论页面展示相关信息并支持跳转至评论页面。

image

How to test it?

测试友链页面添加评论组件。
测试提交评论后，在评论列表是否能够显示友情链接的 subject 信息。

Which issue(s) this PR fixes:

Fixes #63

Does this PR introduce a user-facing change?

为友情链接页面适配评论插件

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 13, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby June 13, 2024 09:30
guqing
guqing approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2024
@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jun 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 90ff2c0 into halo-sigs:main Jun 13, 2024
@LIlGG LIlGG deleted the feat/adapt-comment-component branch June 14, 2024 04:11
@ruibaby ruibaby mentioned this pull request Jul 14, 2024
Closed
@LIlGG LIlGG mentioned this pull request Aug 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guqing guqing guqing approved these changes

@ruibaby ruibaby Awaiting requested review from ruibaby

Assignees

@guqing guqing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

插件不支持评论展示
2 participants
@LIlGG @guqing