Skip to content

Conversation

Roozenlz
Copy link
Contributor

@Roozenlz Roozenlz commented Aug 2, 2023

fix #42
已测试通过

None

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Aug 2, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang August 2, 2023 17:04
@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 3, 2023
@ruibaby ruibaby changed the title build: upgrade the dependency to implement the ExtensionVoOperator interface for the VO classes chore: upgrade the dependency to implement the ExtensionVoOperator interface for the VO classes Aug 3, 2023
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2023
@JohnNiang
Copy link
Collaborator

/hold

需要测试一下兼容性。

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2023
@JohnNiang
Copy link
Collaborator

/unhold

经测试,能够正常安装在 2.1 及以上的版本。不过因引入了 AnnotationForm 扩展点,所以只能在 Halo 2.8 上完全正常工作,我将提交新的 PR 来保证当前插件只能在 2.8 及以上的版本中运行。

@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2023
@guqing
Copy link
Member

guqing commented Aug 3, 2023

/hold

需要测试一下兼容性。

此 PR 不需要测试对低版本的兼容性, link 在这个版本加了 annotation 组件必须 2.8 及以上才能用 低版本都无法提交,所以发版时需要修改 spec.requires>=2.8.0

@f2c-ci-robot f2c-ci-robot bot merged commit 455a7dc into halo-sigs:main Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run.halo.links.vo 包下的类没有实现run.halo.app.theme.finders.vo.ExtensionVoOperator 接口
4 participants