Skip to content

Conversation

guqing
Copy link
Member

@guqing guqing commented Jun 30, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

支持通过页面匹配规则使用代码高亮功能

匹配规则使用 Apache Ant 风格的路径,有三种通配符匹配方法,它们可以组合出很多种灵活的路径模式:

  • ? 匹配任何单字符
  • * 匹配 0 或者任意数量的字符
  • ** 匹配 0 或者更多的层级路径

示例:

  • com/t?st.jsp — matches com/test.jsp but also com/tast.jsp or com/txst.jsp
  • com/*.jsp — matches all .jsp files in the com directory
  • com/**/test.jsp — matches all test.jsp files underneath the com path
  • org/springframework/**/*.jsp — matches all .jsp files underneath the org/springframework path
  • org/**/servlet/bla.jsp — matches org/springframework/servlet/bla.jsp but also org/springframework/testing/servlet/bla.jsp and org/servlet/bla.jsp
  • com/{filename:\\w+}.jsp will match com/test.jsp and assign the value test to the filename variable

Which issue(s) this PR fixes:

Fixes #6

Does this PR introduce a user-facing change?

支持通过页面匹配规则使用代码高亮功能

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 30, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and ruibaby June 30, 2023 06:39
@ruibaby ruibaby closed this Jun 30, 2023
@ruibaby ruibaby deleted the feature/6 branch June 30, 2023 07:00
@ruibaby ruibaby restored the feature/6 branch June 30, 2023 07:00
@ruibaby ruibaby reopened this Jun 30, 2023
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2023
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2023
Copy link
Contributor

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jun 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit c25f8cd into main Jun 30, 2023
@JohnNiang JohnNiang deleted the feature/6 branch July 3, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

增加通过路由匹配的方式进行代码注入的功能
3 participants