Skip to content

Fix existence check of posts in some cases #7673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2025

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind bug
/area core
/milestone 2.21.x

What this PR does / why we need it:

This PR fixes the internal check of selector converter NotEquals, which might lead to failing check of metadata.name!=1.

Which issue(s) this PR fixes:

Fixes #7666

Does this PR introduce a user-facing change?

修复极端场景下无法检查文章别名是否存在的问题

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 8, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.21.x milestone Aug 8, 2025
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Aug 8, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby August 8, 2025 11:12
Copy link

sonarqubecloud bot commented Aug 8, 2025

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2025
Copy link

f2c-ci-robot bot commented Aug 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit 17643bc into main Aug 8, 2025
9 checks passed
@JohnNiang JohnNiang deleted the bug/selector-converter branch August 9, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

点击文章设置报错
2 participants