Skip to content

Add social login endpoint for remember-me support #7670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 8, 2025

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind feature
/kind api-change
/area core
/milestone 2.21.x

What this PR does / why we need it:

This PR adds a new endpoint POST /login/social/{auth_provider_name}?remember-me=true to make the social login support remember-me mechanism.

Does this PR introduce a user-facing change?

支持社交登录时选择是否保持登录

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 7, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.21.x milestone Aug 7, 2025
@f2c-ci-robot f2c-ci-robot bot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API area/core Issues or PRs related to the Halo Core labels Aug 7, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and wan92hen August 7, 2025 04:39
ruibaby and others added 2 commits August 7, 2025 12:53
@JohnNiang
Copy link
Member Author

Hi @ruibaby , please help me refactor the login template to allow users to select Remember Me against social logins.

Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby
Copy link
Member

ruibaby commented Aug 8, 2025

Hi @ruibaby , please help me refactor the login template to allow users to select Remember Me against social logins.

Done

Copy link

sonarqubecloud bot commented Aug 8, 2025

@JohnNiang JohnNiang changed the title WIP: Add social login endpoint for remember-me support Add social login endpoint for remember-me support Aug 8, 2025
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 8, 2025
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2025
Copy link

f2c-ci-robot bot commented Aug 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit 576dda9 into main Aug 8, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants