Skip to content

feat: add thumbnail records modal #7630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 22, 2025
Merged

feat: add thumbnail records modal #7630

merged 3 commits into from
Jul 22, 2025

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jul 15, 2025

What type of PR is this?

/area ui
/kind feature
/milestone 2.21.x

What this PR does / why we need it:

Add thumbnail records viewing feature. The main goal is to keep track of failed thumbnail generations, making it easier to check if thumbnails were generated correctly and retry if needed.

image image

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

支持查看附件缩略图记录

@ruibaby
feat: add thumbnail records modal
c0b9717 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 15, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.21.x milestone Jul 15, 2025
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 15, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and wan92hen July 15, 2025 07:16
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 15, 2025 •
edited
Loading

Open in StackBlitz

@halo-dev/api-client

npm i https://pkg.pr.new/@halo-dev/api-client@7630

@halo-dev/components

npm i https://pkg.pr.new/@halo-dev/components@7630

@halo-dev/richtext-editor

npm i https://pkg.pr.new/@halo-dev/richtext-editor@7630

@halo-dev/console-shared

npm i https://pkg.pr.new/@halo-dev/console-shared@7630

@halo-dev/ui-plugin-bundler-kit

npm i https://pkg.pr.new/@halo-dev/ui-plugin-bundler-kit@7630

commit: 963cc9a

@ruibaby
Fix style
963cc9a 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov Codecov
Copy link

codecov bot commented Jul 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 59.64%. Comparing base (42c374d) to head (963cc9a).
Report is 106 commits behind head on main.

Files with missing lines Patch % Lines
...ain/java/run/halo/app/infra/SchemeInitializer.java 50.00% 4 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #7630      +/-   ##
============================================
+ Coverage     59.55%   59.64%   +0.09%     
+ Complexity     3812     3789      -23     
============================================
  Files           677      676       -1     
  Lines         23248    23105     -143     
  Branches       1500     1483      -17     
============================================
- Hits          13846    13782      -64     
+ Misses         8764     8687      -77     
+ Partials        638      636       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JohnNiang
JohnNiang approved these changes Jul 22, 2025
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2025
@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jul 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit 395399f into halo-dev:main Jul 22, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnNiang JohnNiang JohnNiang approved these changes

@LIlGG LIlGG Awaiting requested review from LIlGG

@wan92hen wan92hen Awaiting requested review from wan92hen

Assignees

@JohnNiang JohnNiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.21.x
Development

Successfully merging this pull request may close these issues.
2 participants
@ruibaby @JohnNiang