Skip to content

feat: add slug existence check when creating posts #7617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 27, 2025

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jul 6, 2025

What type of PR is this?

/area ui
/kind improvement
/milestone 2.21.x

What this PR does / why we need it:

This PR adds frontend support for checking whether an slug already exists when creating posts.

Note:

  1. The current implementation isn’t perfect, some actions (like clicking the “Publish” button) don’t check for duplicate slug yet.
  2. Slug checking in the user center might not be accurate, since it may not have permission to query all posts.
image

Which issue(s) this PR fixes:

Fixes #7615
Fixes #3332

Special notes for your reviewer:

Does this PR introduce a user-facing change?

创建文章时支持检查别名是否重复

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/ui Issues or PRs related to the Halo UI labels Jul 6, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.21.x milestone Jul 6, 2025
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Jul 6, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and LIlGG July 6, 2025 10:02
Signed-off-by: Ryan Wang <i@ryanc.cc>
Copy link

codecov bot commented Jul 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.65%. Comparing base (42c374d) to head (8d31abf).
⚠️ Report is 108 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7617      +/-   ##
============================================
+ Coverage     59.55%   59.65%   +0.09%     
+ Complexity     3812     3789      -23     
============================================
  Files           677      676       -1     
  Lines         23248    23097     -151     
  Branches       1500     1483      -17     
============================================
- Hits          13846    13778      -68     
+ Misses         8764     8683      -81     
+ Partials        638      636       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2025
Copy link

f2c-ci-robot bot commented Jul 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit 2cf0d68 into halo-dev:main Jul 27, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

文章别名重复时,相关详情页访问出现问题 具有相同别名的文章删除某一个后出现问题
2 participants