Skip to content

feat: add support for remote URL attachment downloads #7602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 4, 2025

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jun 27, 2025

What type of PR is this?

/area ui
/kind feature
/milestone 2.21.x

What this PR does / why we need it:

Add support for remote URL attachment downloads

image

Which issue(s) this PR fixes:

Fixes #7017

Does this PR introduce a user-facing change?

支持通过远程地址下载到附件库

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/ui Issues or PRs related to the Halo UI labels Jun 27, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.21.x milestone Jun 27, 2025
@f2c-ci-robot f2c-ci-robot bot requested a review from guqing June 27, 2025 10:30
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 27, 2025
@f2c-ci-robot f2c-ci-robot bot requested a review from LIlGG June 27, 2025 10:30
@ruibaby ruibaby changed the title feat: add support for remote URL attachment downloads WIP: feat: add support for remote URL attachment downloads Jun 27, 2025
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 27, 2025
Copy link

pkg-pr-new bot commented Jun 30, 2025

Open in StackBlitz

@halo-dev/api-client

npm i https://pkg.pr.new/@halo-dev/api-client@7602

@halo-dev/components

npm i https://pkg.pr.new/@halo-dev/components@7602

@halo-dev/richtext-editor

npm i https://pkg.pr.new/@halo-dev/richtext-editor@7602

@halo-dev/console-shared

npm i https://pkg.pr.new/@halo-dev/console-shared@7602

@halo-dev/ui-plugin-bundler-kit

npm i https://pkg.pr.new/@halo-dev/ui-plugin-bundler-kit@7602

commit: fc55cb1

@ruibaby ruibaby changed the title WIP: feat: add support for remote URL attachment downloads feat: add support for remote URL attachment downloads Jun 30, 2025
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 30, 2025
Copy link

Copy link

codecov bot commented Jun 30, 2025

Codecov Report

Attention: Patch coverage is 55.55556% with 8 lines in your changes missing coverage. Please review.

Project coverage is 59.63%. Comparing base (42c374d) to head (fc55cb1).
Report is 95 commits behind head on main.

Files with missing lines Patch % Lines
...app/infra/DefaultReactiveUrlDataBufferFetcher.java 50.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7602      +/-   ##
============================================
+ Coverage     59.55%   59.63%   +0.07%     
+ Complexity     3812     3788      -24     
============================================
  Files           677      676       -1     
  Lines         23248    23088     -160     
  Branches       1500     1482      -18     
============================================
- Hits          13846    13768      -78     
+ Misses         8764     8684      -80     
+ Partials        638      636       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2025
Copy link

f2c-ci-robot bot commented Jul 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit a4a418b into halo-dev:main Jul 4, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

支持远程下载
3 participants