-
-
Notifications
You must be signed in to change notification settings - Fork 10k
feat: add support for remote URL attachment downloads #7602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
@halo-dev/api-client
@halo-dev/components
@halo-dev/richtext-editor
@halo-dev/console-shared
@halo-dev/ui-plugin-bundler-kit
commit: |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7602 +/- ##
============================================
+ Coverage 59.55% 59.63% +0.07%
+ Complexity 3812 3788 -24
============================================
Files 677 676 -1
Lines 23248 23088 -160
Branches 1500 1482 -18
============================================
- Hits 13846 13768 -78
+ Misses 8764 8684 -80
+ Partials 638 636 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/area ui
/kind feature
/milestone 2.21.x
What this PR does / why we need it:
Add support for remote URL attachment downloads
Which issue(s) this PR fixes:
Fixes #7017
Does this PR introduce a user-facing change?