-
-
Notifications
You must be signed in to change notification settings - Fork 10k
refactor: optimize indentation behavior #7600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@halo-dev/api-client
@halo-dev/components
@halo-dev/richtext-editor
@halo-dev/console-shared
@halo-dev/ui-plugin-bundler-kit
commit: |
Fixes #7492 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7600 +/- ##
============================================
+ Coverage 59.55% 59.64% +0.08%
+ Complexity 3812 3788 -24
============================================
Files 677 676 -1
Lines 23248 23077 -171
Branches 1500 1483 -17
============================================
- Hits 13846 13764 -82
+ Misses 8764 8678 -86
+ Partials 638 635 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/area editor
/kind improvement
/milestone 2.21.x
What this PR does / why we need it:
Fixes #7492
优化默认编辑器中缩进的逻辑。现在使用 Tab 对文本进行缩进之后,再按 Backspace 会优先回退缩进。
并且原有的文本会直接删除其上一个节点,现在只有块级节点会被直接删除。
before:
after:
How to test it?
测试使用 Backspace 是否符合正常逻辑。
Does this PR introduce a user-facing change?