Skip to content

refactor: optimize indentation behavior #7600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Jun 27, 2025

What type of PR is this?

/area editor
/kind improvement
/milestone 2.21.x

What this PR does / why we need it:

Fixes #7492

优化默认编辑器中缩进的逻辑。现在使用 Tab 对文本进行缩进之后,再按 Backspace 会优先回退缩进。
并且原有的文本会直接删除其上一个节点,现在只有块级节点会被直接删除。

before:

Kapture 2025-06-27 at 17 53 16

after:

Kapture 2025-06-27 at 17 57 01

How to test it?

测试使用 Backspace 是否符合正常逻辑。

Does this PR introduce a user-facing change?

优化默认编辑器缩进逻辑

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/editor Issues or PRs related to the Editor labels Jun 27, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.21.x milestone Jun 27, 2025
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Jun 27, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby June 27, 2025 10:10
Copy link

Copy link

pkg-pr-new bot commented Jun 27, 2025

Open in StackBlitz

@halo-dev/api-client

npm i https://pkg.pr.new/@halo-dev/api-client@7600

@halo-dev/components

npm i https://pkg.pr.new/@halo-dev/components@7600

@halo-dev/richtext-editor

npm i https://pkg.pr.new/@halo-dev/richtext-editor@7600

@halo-dev/console-shared

npm i https://pkg.pr.new/@halo-dev/console-shared@7600

@halo-dev/ui-plugin-bundler-kit

npm i https://pkg.pr.new/@halo-dev/ui-plugin-bundler-kit@7600

commit: a94bfd0

@LIlGG
Copy link
Member Author

LIlGG commented Jun 27, 2025

Fixes #7492

@LIlGG LIlGG linked an issue Jun 27, 2025 that may be closed by this pull request
4 tasks
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.64%. Comparing base (42c374d) to head (a94bfd0).
Report is 90 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7600      +/-   ##
============================================
+ Coverage     59.55%   59.64%   +0.08%     
+ Complexity     3812     3788      -24     
============================================
  Files           677      676       -1     
  Lines         23248    23077     -171     
  Branches       1500     1483      -17     
============================================
- Hits          13846    13764      -82     
+ Misses         8764     8678      -86     
+ Partials        638      635       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LIlGG LIlGG linked an issue Jun 27, 2025 that may be closed by this pull request
4 tasks
@ruibaby ruibaby changed the title pref: optimize indentation behavior refactor: optimize indentation behavior Jun 30, 2025
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2025
Copy link

f2c-ci-robot bot commented Jun 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit 07737f9 into halo-dev:main Jun 30, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/editor Issues or PRs related to the Editor kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

默认编辑器使用体验上有些问题。 halo文章编辑器 使用体验不好
2 participants